Inbound Channel Adapter Parser doesn't generate unique bean Id for MessageSources [INT-3240]

[spring-operator]

Simon Wong opened INT-3240 and commented

I found that the following configuration won't deliver any file message. Same configuration works for v2.2.6

<int-file:inbound-channel-adapter directory="some_directory"
                                  prevent-duplicates="true"
                                  channel="someChannel">
    <int:poller receive-timeout="5000" fixed-rate="50" />
</int-file:inbound-channel-adapter>
<int:channel id="someChannel" />

---

Affects: 3.0 GA

Attachments:

• input.zip (1.71 kB)
• test_case.zip (1.57 kB)

Issue Links:

• Bug in org.springframework.integration.config.xml.AbstractPollingInboundChannelAdapterParser.doParse [INT-3267] #7242 Bug in org.springframework.integration.config.xml.AbstractPollingInboundChannelAdapterParser.doParse
  ("is duplicated by")

• MetadataStore Key is named '(inner bean)' [INT-3147] #7119 MetadataStore Key is named '(inner bean)'

• Regression: Class cast exception using DefaultInboundChannelAdapterParser [INT-3300] #7274 Regression: Class cast exception using DefaultInboundChannelAdapterParser

[spring-operator]

Artem Bilan commented

Looks like you have some other issue in your application, not about File Inbound.
Here is a test case, which similar to your config:

<int-file:inbound-channel-adapter directory="d:\Downloads"
	  prevent-duplicates="true"
	  channel="someChannel">
   <int:poller receive-timeout="5000" fixed-rate="50" />
</int-file:inbound-channel-adapter>

<int:channel id="someChannel">
	<int:queue/>
</int:channel>

@ContextConfiguration
@RunWith(SpringJUnit4ClassRunner.class)
public class FileToChannelIntegrationTests {

	@Autowired
	PollableChannel someChannel;

	@Test
	public void testInt3240() throws Exception {
		Set<Message<?>> files = new HashSet<Message<?>>();
		while (true) {
			assertTrue(files.add(this.someChannel.receive(1000)));
			assertTrue(files.size() > 0);
			System.out.println(files);
		}
	}
}

This test fails when all files from my directory will be readed.

Try to find an issue in other place.

[spring-operator]

Gary Russell commented

Do you still have an issue, or can we close this?

Thanks

[spring-operator]

Simon Wong commented

Sorry for the late reply. I finally could reproduce the problem. The problem arose when more than 1 file-inbound/outbound adapter appears in the same applicationContext.

[spring-operator]

Simon Wong commented

It works for SI v2.2.6 but failed on SI v3.0.
Only the files from source2 (b1.txt and b2.txt) will be copied.
Also, I found some strange behavior. The files from source2 might not always consistently copied to target2 directory. It might copied to target1 directory occasionally.

[spring-operator]

Artem Bilan commented

Show, please, your configuration to check and reproduce

[spring-operator]

Simon Wong commented

The attached test case is not enough to reproduce the issue?

[spring-operator]

Artem Bilan commented

Oh! Sorry, haven't noticed it before. Yes, it is enough. I'll back to you after holydays.

[spring-operator]

Simon Wong commented

Thanks. Happy New Year

[spring-operator]

Artem Bilan commented

Happy New Year you too!
Good and bad news: I've reproduced it and found the issue. And it is really big regression since 3.0.
To fix it now as workaround you should provide an id attribute for all inbound channel adapters.
And I'm going to fix it after holydays.
Cheers

[spring-operator]

Simon Wong commented

Thanks for the workaround solution

[spring-operator]

Artem Bilan commented

PR: #1019

[spring-operator]

Gary Russell commented

Merged in master; cherry-picked to 3.0.x.