fixed issue where expired timestamp on cookie.toString method produce… #1857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@baskuis Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@baskuis Thank you for signing the Contributor License Agreement! |
|
@baskuis, thanks but could you create a ticket in https://jira.spring.io/browse/SPR, please? |
|
I've created https://jira.spring.io/browse/SPR-16940. |
|
@rstoyanchev - will do next time! (sorry don't know the process) :-) |
|
No worries, it's important for tracking purposes, also for priority and fix versions. I've gone ahead and fixed this all around, including the max-age value, plus adding tests. Thanks for the report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expires date is not correctly generated.
The max age duration as seconds is added to the system time in millis.
@rstoyanchev - not sure if you already caught this ?