Error handling override in DefaultResponseErrorHandler ignored after upgrade to 6.2.0

[blopatka]

Change introduced in spring 6.2.0 changes the behavior of DefaultResponseErrorHandler.

Until now

spring-framework/spring-web/src/main/java/org/springframework/web/client/DefaultResponseErrorHandler.java

Line 161 in 5024bb7

public void handleError(URI url, HttpMethod method, ClientHttpResponse response) throws IOException {

method didn't exist and the default implementation from interface was calling handleError(ClientHttpResponse response) method, right now the behavior is broken and the said method is not being called.

In classess derived from the DefaultResponseErrorHandler when overriding only handleError(ClientHttpResponse response), the error handling stops working properly, as now the call to the method is completely ommited.

This happened without any notice in release notes, my custom error handler stopped working, errors were only default processed.

[rstoyanchev]

Thanks for the report.

Technically not a regression since the goal in #28958 was switch to the new method, but we didn't document it in the migration notes, and I think we can make it backwards compatible by making handleError(response) no-op, and calling it first. If it doesn't raise an exception, we proceed in the new 6.2 method.

We'll also deprecate the handleError(response) as it is no longer called directly.

[blopatka]

Switching to the new method is fine, but right now the 1-argument 'handleError method is totally omitted in RestTemplate lifecycle. It's fine to remove the method, but as long as it's not removed it should be included in the lifecycle.
Right now I have a dozen of not working ErrorHandlers. For some i can perform migration to the new method right away, others are in compiled libs so migration is not straightforward.
Keep in mind that this change is not causing any compile time errors. Just on the runtime my clients would get responses that in case of errors would be not handled properly.

[rstoyanchev]

We're not removing the method yet, only deprecating it, and during the deprecation phase it will continue to be called. This is why I put the "regression" label.