InterceptingHttpAccessor.setInterceptors should support immutable lists [SPR-16137]

[spring-projects-issues]

Joakim Lindberg opened SPR-16137 and commented

When upgrading from org.springframework:spring-web:4.2.4.RELEASE our httpinterceptors stopped working because we used immutable list as input to InterceptingHttpAccessor.setInterceptors. That method now use AnnotationAwareOrderComparator.sort(interceptors) and in extent Collections.sort which is not side effect free.

InterceptingHttpAccessor.setInterceptors should use a copied list to sort on.

---

Affects: 5.0 GA, 5.0.1

Issue Links:

• Update RestTemplate to respect @Order for ClientHttpRequestInterceptor [SPR-13971] #18543 Update RestTemplate to respect @Order for ClientHttpRequestInterceptor

Referenced from: commits d06129d

[spring-projects-issues]

Juergen Hoeller commented

I've aligned this with RestTemplate.setMessageConverters, operating on a fixed internal ArrayList that the setter copies the given list to (and which we can then reliably sort).

We're also caching the InterceptingClientHttpRequestFactory instance now as long as the original factory hasn't changed.