Skip to content

DATAREST-1407 - Updated example for customizing resource URLs. #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

benwarfield-usds
Copy link
Contributor

@benwarfield-usds benwarfield-usds commented Jul 8, 2019

Removed the reference to the deprecated RepositoryRestConfigurerAdapter, and updated the entity-lookup/ID translation example to use the currently supported API.

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • N/A You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • N/A You submit test cases (unit or integration tests) that back your changes.
  • N/A You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Obvious fix (in my personal opinion, at least).

Removed the reference to the deprecated RepositoryRestConfigurerAdapter, and updated the entity-lookup/ID translation example to use the currently supported API.
@pivotal-issuemaster
Copy link

@benwarfield-usds Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@benwarfield-usds This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

odrotbohm pushed a commit that referenced this pull request Jul 9, 2019
Removed the reference to the deprecated RepositoryRestConfigurerAdapter, and updated the entity-lookup/ID translation example to use the currently supported API.

Original pull request: #359.
odrotbohm pushed a commit that referenced this pull request Jul 9, 2019
Removed the reference to the deprecated RepositoryRestConfigurerAdapter, and updated the entity-lookup/ID translation example to use the currently supported API.

Original pull request: #359.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 4, 2021
@gregturn gregturn changed the base branch from master to main April 16, 2021 17:55
@benwarfield-usds
Copy link
Contributor Author

The change appears to have been cherry-picked and/or superseded last summer some time, so I'm going to close this. 🙂

@pivotal-cla
Copy link

@benwarfield-usds Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

1 similar comment
@pivotal-cla
Copy link

@benwarfield-usds Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@odrotbohm
Copy link
Member

Thanks, Ben!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants