Deletes and updates to capped collections fail silently [DATAMONGO-561]

[spring-projects-issues]

Tobias Trelle opened DATAMONGO-561 and commented

MongoDB does not support deletes and updates of documents in a capped collection. Using repository methods like delete(...) and save(...) should throw an exception when operating on a domain object mapped to a capped collection. Right now these methods do not fail, but they also don't delete or update anything (I provided a test case for that, see Reference URL)

---

Affects: 1.1 GA

Reference URL: https://github.com/ttrelle/spring-data-examples/blob/master/springdata-mongodb/src/test/java/mongodb/CappedCollectionManipulationTest.java

[spring-projects-issues]

Tobias Trelle commented

To be more precise:

• delete are always forbidden

• updates are forbidden only if the updapte causes the document to grow is size (what would case a relocation on disk)

See http://docs.mongodb.org/manual/core/capped-collections/

[spring-projects-issues]

Oliver Drotbohm commented

I am not sure we really should take action here. If something is really forbidden or discouraged to be done within MongoDB, the MongoDB Java driver should throw an exception actually. Otherwise we might introduce a guard that might become invalid once MongoDB might allow this behavior. I'll speck to the 10gen guys on what they think is best

[spring-projects-issues]

Mark Paluch commented

Deletes are now properly reported and updates work:

 

org.springframework.dao.DataIntegrityViolationException: cannot remove from a capped collection: test.fooModel; nested exception is com.mongodb.MongoWriteException: cannot remove from a capped collection: test.fooModel

	at org.springframework.data.mongodb.core.MongoExceptionTranslator.translateExceptionIfPossible(MongoExceptionTranslator.java:112)
	at org.springframework.data.mongodb.core.MongoTemplate.potentiallyConvertRuntimeException(MongoTemplate.java:2921)
	at org.springframework.data.mongodb.core.MongoTemplate.execute(MongoTemplate.java:586)
	at org.springframework.data.mongodb.core.MongoTemplate.doRemove(MongoTemplate.java:1760)
	at org.springframework.data.mongodb.core.MongoTemplate.remove(MongoTemplate.java:1730)
	at org.springframework.data.mongodb.core.MongoTemplate.remove(MongoTemplate.java:1719)
	at org.springframework.data.mongodb.core.aggregation.Foo.name(Foo.java:44)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
Caused by: com.mongodb.MongoWriteException: cannot remove from a capped collection: test.fooModel
	at com.mongodb.client.internal.MongoCollectionImpl.executeSingleWriteRequest(MongoCollectionImpl.java:1055)
	at com.mongodb.client.internal.MongoCollectionImpl.executeDelete(MongoCollectionImpl.java:1021)
	at com.mongodb.client.internal.MongoCollectionImpl.deleteOne(MongoCollectionImpl.java:534)
	at org.springframework.data.mongodb.core.MongoTemplate.lambda$doRemove$22(MongoTemplate.java:1802)
	at org.springframework.data.mongodb.core.MongoTemplate.execute(MongoTemplate.java:584)
	... 26 more
 

[spring-projects-issues]

Mark Paluch commented

Closing as things work now as designed