Allow repositories to work with interfaces as domain type [DATAMONGO-131]

[spring-projects-issues]

Oliver Drotbohm opened DATAMONGO-131 and commented

With the fix for issue DATAMONGO-128 we allow persisting inheritance structures with repositories. Unfortunately executing findOne(…) uses MongoEntityInformation to lookup the id property to pipe it into the query. This id property is discovered from the domain class the repository manages. This implies that this type carries the id property which doesn't have to be the case (it actually can't be the case for interfaces as managed root type).

So we should use the MongoTemplate's MappingContext instead to ask it for the entity meta information of the given object instead of the type managed by the repo

---

Affects: 1.0 M2

9 votes, 9 watchers

[spring-projects-issues]

Jacob Metcalf commented

Do you plan to also support finding by an interface's getter/setters i.e.:

public interface PersonRepository extends PagingAndSortingRepository<Person, String> {

   List<Person> findByLastName( String lastName );
}

Where Person is an interface. I have posted an example and some debuggiong of what happens currently at:

http://forum.springsource.org/showthread.php?108899-Polymorphism-for-spring-data&p=371336#post371336

[spring-projects-issues]

Oliver Drotbohm commented

That's exactly what this ticket is all about :)

[spring-projects-issues]

Robyn Lenore commented

It's very confusing that Spring Data MongoDB repositories work differently than the JpaRepository in this regard! Not being able to create polymorphic queries has really limited the usefulness of Spring Data for me

[spring-projects-issues]

Oliver Drotbohm commented

What is it you consider different? In both JPA and MongDB repositories the domain class the repository (method) is typed to currently has to carry the ID attribute. So you actually can create polymorphic queries. So I'd be interested to hear what specific things get in your way

[spring-projects-issues]

Jarrah Watson commented

whats the status of this issue? i noticed on the accompanying thread this ticket was due to be resolved in 1.1-M1 but still seems to be open.

using an interface as the repository domain type would be extremely useful

[spring-projects-issues]

Christoph Strobl commented

The issue has been resolved during the past few years and now works as designed with current master (3.0).

@ExtendWith(SpringExtension.class)
@ContextConfiguration
public class Datamongo131 {

	@EnableMongoRepositories(considerNestedRepositories = true)
	static class Config extends AbstractMongoClientConfiguration {

		@Override
		protected String getDatabaseName() {
			return "datamongo-131";
		}
	}

	@Autowired DomainTypeRepo repo;

	@BeforeEach
	void beforeEach() {
		repo.deleteAll();
	}

	@Test
	void storeAndFind() {

		Person source = new Person();
		source.name = "batman";
		repo.save(source);

		Assertions.assertThat(repo.findById(source.id)).contains(source);
	}

	interface DomainType {

		String getName();

	}

	@Data
	static class Person implements DomainType {

		@Id String id;
		String name;

		@Override
		public String getName() {
			return name;
		}
	}

	interface DomainTypeRepo extends CrudRepository<DomainType, String> {

	}

}