Skip to content

Make identification variables and the SELECT clause in JPQL optional #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Make identification variables and the SELECT clause in JPQL optional #3903

wants to merge 5 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented May 28, 2025 •
edited
Loading

Closes #3902

@mp911de mp911de changed the title Issue/3902 Make identification variables and the SELECT clause in JPQL optional May 28, 2025
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 28, 2025
@mp911de mp911de added this to the 4.0 M4 (2025.1.0) milestone May 28, 2025
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 28, 2025
christophstrobl
christophstrobl reviewed Jul 3, 2025
View reviewed changes
spring-data-jpa/src/main/antlr4/org/springframework/data/jpa/repository/query/Jpql.g4
;

identification_variable_declaration
: range_variable_declaration (join | fetch_join)*
;

range_variable_declaration
: entity_name AS? identification_variable
: entity_name AS? identification_variable?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about entity_name (AS? identification_variable)? ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

...a-jpa/src/test/java/org/springframework/data/jpa/repository/query/EqlQueryRendererTests.java

@Test
void whereClause() {
// TBD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we missing a test here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Likely, my bad.

mp911de added a commit that referenced this pull request Jul 7, 2025
@mp911de
Make identification variables and the SELECT clause in JPQL optional.
d9c102e 
Original pull request: #3903
Closes #3902
mp911de added a commit that referenced this pull request Jul 7, 2025
@mp911de
Polishing.
fa30902 
Align test methods between EQL and JPQL.
Refine identification variable syntax grouping. Align and simplify EQL and JPQL renderers.

See #3902
Original pull request: #3903
@mp911de mp911de closed this Jul 7, 2025
@mp911de mp911de deleted the issue/3902 branch July 7, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophstrobl christophstrobl christophstrobl left review comments

Assignees

@christophstrobl christophstrobl

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.0 M4 (2025.1.0)
Development

Successfully merging this pull request may close these issues.

Make identification variables and the SELECT clause in JPQL optional
3 participants
@mp911de @christophstrobl @spring-projects-issues