@GraphQlTest does not include @ControllerAdvice#49660
Merged
snicoll merged 2 commits intospring-projects:3.5.xfrom Mar 20, 2026
Merged
@GraphQlTest does not include @ControllerAdvice#49660snicoll merged 2 commits intospring-projects:3.5.xfrom
snicoll merged 2 commits intospring-projects:3.5.xfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
@GraphQlTest should load @ControllerAdvice@GraphQlTest does not include @ControllerAdvice
snicoll
changed the title
@GraphQlTest does not include @ControllerAdvice
wilkinsona
changed the title
wilkinsona
added
type: bug
This commit updates the GraphQL slice tests to also consider `@ControllerAdvice`-annotated beans, since Spring GraphQL loads `@GraphQlExceptionHandler`s declared in `@ControllerAdvice` beans. This also aligns `@GraphQlTest` with `@WebMvcTest`. See spring-projectsgh-49660 Signed-off-by: Louis Morgan <ljrmorgan@gmail.com>
snicoll
force-pushed
the
graphql_test_should_load_controller_advice
branch
from
b4eec55 to
af03b3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQL slice tests should load
@ControllerAdvicebeans, since Spring GraphQL will load@GraphQlExceptionHandlers declared in@ControllerAdvicebeans.This aligns
@GraphQlTestwith@WebMvcTest, which does load@ControllerAdvicebeans.Closes #49659