Skip to content

Javadoc of JettyHttpClientBuilder refers to the wrong type#49364

Closed
chandanv89 wants to merge 1 commit intospring-projects:mainfrom
chandanv89:fix-javadoc-typos-http-client
Closed

Javadoc of JettyHttpClientBuilder refers to the wrong type#49364
chandanv89 wants to merge 1 commit intospring-projects:mainfrom
chandanv89:fix-javadoc-typos-http-client

Conversation

@chandanv89
Copy link
Copy Markdown
Contributor

Fix 'Rector' typo in ReactorHttpClientBuilder class Javadoc and correct JettyHttpClientBuilder method Javadoc that incorrectly referenced JettyClientHttpRequestFactoryBuilder instead of JettyHttpClientBuilder.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 2, 2026
@snicoll
Copy link
Copy Markdown
Member

snicoll commented Mar 2, 2026

@chandanv89 thanks for the PR. Please sign-off your commit as the DCO check is failing at the moment.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Mar 2, 2026
@chandanv89 chandanv89 force-pushed the fix-javadoc-typos-http-client branch from bf79ff7 to 83ceec2 Compare March 3, 2026 12:59
Fix 'Rector' typo in ReactorHttpClientBuilder class Javadoc and
correct JettyHttpClientBuilder method Javadoc that incorrectly
referenced JettyClientHttpRequestFactoryBuilder instead of
JettyHttpClientBuilder.

Signed-off-by: Chandan Veerabhadrappa <chandan.veerabhadrappa@aerlingus.com>
@chandanv89 chandanv89 force-pushed the fix-javadoc-typos-http-client branch from 83ceec2 to 1660a10 Compare March 3, 2026 13:01
@chandanv89
Copy link
Copy Markdown
Contributor Author

@snicoll Commit is signed-off now. Thanks

@snicoll snicoll self-assigned this Mar 3, 2026
@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Mar 3, 2026
@snicoll snicoll changed the title Fix typo and incorrect Javadoc references in HTTP client builders Javadoc of JettyHttpClientBuilder refers to the wrong type Mar 3, 2026
@snicoll snicoll added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Mar 3, 2026
@snicoll snicoll added this to the 3.5.12 milestone Mar 3, 2026
snicoll pushed a commit that referenced this pull request Mar 3, 2026
See gh-49364

Signed-off-by: Chandan Veerabhadrappa <chandan.veerabhadrappa@aerlingus.com>
snicoll added a commit that referenced this pull request Mar 3, 2026
@snicoll snicoll closed this in 9b40f3f Mar 3, 2026
@snicoll
Copy link
Copy Markdown
Member

snicoll commented Mar 3, 2026

Thanks @chandanv89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: documentation A documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants