Skip to content

Support overriding the default key-based sanitization #30006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

terminux
Copy link
Contributor

Hi, I submitted this PR to solve #29620 based on @philwebb ’s comment.

When a value has been sanitized already, later functions can skip it.

Closes gh-29620

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 28, 2022
@philwebb philwebb added the for: team-meeting An issue we'd like to discuss as a team to make progress label Feb 28, 2022
@philwebb
Copy link
Member

philwebb commented Mar 2, 2022

When we look at merging this one we should check that orderedStream() is used to provide the SanitzerFunction beans.

@philwebb philwebb added for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Mar 2, 2022
@philwebb philwebb added this to the 2.7.x milestone Mar 2, 2022
@terminux
Copy link
Contributor Author

terminux commented Mar 3, 2022

Thank you very much for your reply @philwebb , nice suggestions. I've updated the PR based on your suggestions.

@wilkinsona wilkinsona self-assigned this Mar 3, 2022
@wilkinsona wilkinsona removed the for: merge-with-amendments Needs some changes when we merge label Mar 3, 2022
@wilkinsona wilkinsona modified the milestones: 2.7.x, 2.7.0-M3 Mar 3, 2022
wilkinsona pushed a commit that referenced this pull request Mar 3, 2022
@wilkinsona wilkinsona closed this in 2fec86a Mar 3, 2022
@wilkinsona wilkinsona changed the title Support overriding the default SanitizingFunction Support overriding the default key-based sanitization Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support overriding the default SanitizingFunction
4 participants