Remove usage of deprecated Matchers class #13345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
approved these changes
Jun 4, 2018
snicoll
added
type: task
snicoll
added a commit
that referenced
this pull request
Jun 4, 2018
* pr/13345: Remove usage of deprecated Matchers class
|
Good catch @dreis2211, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
just noticed this deprecation warning. I guess it's safe to remove the call to
same()alltogether and hence the need for the alternativeArgumentMatchersimport as well. Default behaviour should be checking the parameters withequals()which is sufficient here in my opinion.Let me know what you think.
Cheers,
Christoph