Polish #13192
Closed
Polish #13192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
reviewed
May 17, 2018
| @@ -74,10 +74,6 @@ public Whitelabel getWhitelabel() { | |||
| return this.whitelabel; | |||
| } | |||
|
|
|||
| public void setWhitelabel(Whitelabel whitelabel) { | |||
There was a problem hiding this comment.
I'd like to merge this in 2.0.x. This is correct but I prefer to make such a breaking change on master only. Can you please remove it? (I can apply that part manually or feel free to submit a separate PR for that).
snicoll
approved these changes
May 17, 2018
snicoll
added
type: task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some typos and polishes trivial stuff.