-
Notifications
You must be signed in to change notification settings - Fork 41.4k
Description
spring-boot/.github/workflows/release.yml
Line 30 in a3c34b4
build-name: ${{ vars.COMMERCIAL && format('spring-boot-commercial-{0}', github.ref_name) || format('spring-boot-{0}', github.ref_name) }} |
When the release, github.ref_name
will be something like v3.2.11
.
spring-boot/.github/workflows/release.yml
Line 72 in a3c34b4
spring-boot-version: ${{ needs.build-and-stage-release.outputs.version }} |
run: jf rt download --spec ${{ format('{0}/artifacts.spec', github.action_path) }} --spec-vars 'buildName=${{ format('spring-boot-{0}', inputs.spring-boot-version) }};buildNumber=${{ github.run_number }}' |
spring-boot/.github/workflows/release.yml
Line 86 in a3c34b4
run: jfrog rt build-promote ${{ format('spring-boot-{0}', needs.build-and-stage-release.outputs.version)}} ${{ github.run_number }} libs-release-local |
When we release, needs.build-and-stage-release.outputs.version
will be something like 3.2.11
.
This mismatch means that both the artifact download and the build promotion will use the wrong build name and won't find anything to download/promote.
Instead of github.ref_name
, we used to use steps.build-and-publish.outputs.version
. We should probably go back to that unless there's good reason to use the ref_name
instead.