Skip to content

Change visibility of properties in JdbcPagingItemReaderBuilder #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Change visibility of properties in JdbcPagingItemReaderBuilder #4331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions ...ain/java/org/springframework/batch/item/database/builder/JdbcPagingItemReaderBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,33 +56,33 @@
*/
public class JdbcPagingItemReaderBuilder<T> {

private DataSource dataSource;
protected DataSource dataSource;

private int fetchSize = JdbcPagingItemReader.VALUE_NOT_SET;
protected int fetchSize = JdbcPagingItemReader.VALUE_NOT_SET;

private PagingQueryProvider queryProvider;
protected PagingQueryProvider queryProvider;

private RowMapper<T> rowMapper;
protected RowMapper<T> rowMapper;

private Map<String, Object> parameterValues;
protected Map<String, Object> parameterValues;

private int pageSize = 10;
protected int pageSize = 10;

private String groupClause;
protected String groupClause;

private String selectClause;
protected String selectClause;

private String fromClause;
protected String fromClause;

private String whereClause;
protected String whereClause;

private Map<String, Order> sortKeys;
protected Map<String, Order> sortKeys;

private boolean saveState = true;
protected boolean saveState = true;

private String name;
protected String name;

private int maxItemCount = Integer.MAX_VALUE;
protected int maxItemCount = Integer.MAX_VALUE;

private int currentItemCount;

Expand Down Expand Up @@ -329,7 +329,7 @@ public JdbcPagingItemReader<T> build() {
return reader;
}

private PagingQueryProvider determineQueryProvider(DataSource dataSource) {
protected PagingQueryProvider determineQueryProvider(DataSource dataSource) {

try {
DatabaseType databaseType = DatabaseType.fromMetaData(dataSource);
Expand Down Expand Up @@ -394,5 +394,4 @@ private PagingQueryProvider determineQueryProvider(DataSource dataSource) {
throw new IllegalArgumentException("Unable to determine PagingQueryProvider type", e);
}
}

}