Added isXXXEnabled for logging statements #3814
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guarded the logging statements which do concatenation of strings or calling toString on objects. When a log level isn't enabled this still would produce garbage that would need to be collected. Guarded all logging up to info, warn and error can be assumed to be enabled on a production system.
fmbenhassine
added
pr-for: enhancement
has: backports
fmbenhassine
added
in: core
for: backport-to-4.2.x
| if (logger.isDebugEnabled()) { | ||
| logger.debug(resultingQuery); | ||
| } | ||
| logger.debug(resultingQuery); |
There was a problem hiding this comment.
This seems an unintentional change (as it goes against the idea of the PR). I will revert it on merge.
| @@ -61,6 +61,8 @@ public void write(List<? extends Object> items) throws Exception { | |||
| } | |||
|
|
|||
| stepExecution.setWriteCount(++count); | |||
| LOG.info("Executing infinite loop, at count=" + count); | |||
| if (logger.isInfoEnabled()) { | |||
There was a problem hiding this comment.
This line should be if (LOG.isInfoEnabled()) {. I will fix it on merge.
| public void doStronglyTypedLogging(Object item){ | ||
| log.info("Processed: " + item); | ||
| public void doStronglyTypedLogging(Object item) { | ||
| if (logger.isInfoEnabled()) { |
There was a problem hiding this comment.
This line should be if (log.isInfoEnabled()) {. I will fix it on merge.
| StringBuffer valueBuffer = new StringBuffer(); | ||
| StringBuilder valueBuffer = new StringBuilder(); |
There was a problem hiding this comment.
This change creates a compilation error in jobParameterMatcher.appendReplacement and jobParameterMatcher.appendTail. Those methods accept a StringBuilder starting from Java 9 onward. I will revert that change on merge. Please make sure to use Java 8 when building your PR.
|
Rebased and merged as b7d144c. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guarded the logging statements which do concatenation of strings
or calling toString on objects. When a log level isn't enabled
this still would produce garbage that would need to be collected.
Guarded all logging up to info, warn and error can be assumed to be
enabled on a production system.