AbstractCursorItemReader doClose() method is not reentrant [BATCH-2737]

[spring-projects-issues]

Tommy opened BATCH-2737 and commented

The following warning coming up from the DisposableBeanAdapter, when it tries to destroy any reader extended from the AbstractCursorItemReader by the auto-discovered close() method.
DisposableBeanAdapter : Invocation of destroy method 'close' failed on bean with name 'reader': org.springframework.batch.item.ItemStreamException: Error while closing item reader

Since the invocation of the close() method is already part of the Spring-Batch life-cycle, the doClose() method of this class should be reentrant.
The problem lies in the incomplete check around resetting the autoCommit state of the underlying connection, which does not respect the already closed connection.

The check should look like something similar

if(this.con != null && !this.conn.isClosed()) {
	this.con.setAutoCommit(this.initialConnectionAutoCommit);
}

---

Affects: 4.0.0

1 votes, 2 watchers

[spring-projects-issues]

BluAge commented

Hello all,

Can this issue be considered?
Though it is not harmful since it is only a warning, customers may frown upon it and think it denotes a real problem. And it seems easy to fix, according to the OP.
Adding destroyMethod="" to all the @Bean declarations for such readers is really a pain, and getting rid of the warning through logging management is probably not a good idea.

Regards,

[fmbenhassine]

I was not able to reproduce the case (See this repo where the warning does not show up), but I see no harm in adding this extra check to make sure the connection is not closed at that point.

Extra check added in 999ef54.