Skip to content

SimpleCompletionPolicy should have getChunkSize() method. #3738

Closed
@MinJunKweon

Description

@MinJunKweon

Currently, SimpleCompletionPolicy doesn't have getChunkSize().
But toString() method returns a string that include own chunk size by some format.

You can see them on this.

SimpleCompletionPolicy examplePolicy = new SimpleCompletionPolicy(50);
System.out.println(examplePolicy.toString());
// SimpleCompletionPolicy: chunkSize=50

I think it is a code smell.
If I want to get its chunk size, I have to parse toString() result. It is a very ugly way.

I suggest two options to solve this.

  1. Make toString() doesn't show own chunk size.
  2. Make getChunkSize() public method.

In my opinion, It should be second option.
If you approve this idea, comment, please. And then, I will make a pull request for this.

Thank you.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions