Upgrade Jettison to 1.3.x [BATCH-2575]

[spring-projects-issues]

Derek Lewis opened BATCH-2575 and commented

Spring Batch currently depends on Jettison 1.2, which conflicts with other Spring Boot modules, like Spring Cloud Netflix. Specifically, Eureka has a dependency for Jettison 1.3.x. If an application utilizes both Eureka and Spring Batch, then XStream exceptions are generated when utilizing JobExplorer.

Jettison 1.2 is also very old. It was released in 2010.

---

Affects: 3.0.7

Referenced from: commits 4ad0016

Backported to: 4.0.0.M2

0 votes, 5 watchers

[spring-projects-issues]

Derek Lewis commented

Also, Eureka "appears" to work with Jettison 1.2.x, so I was able to manually specify the dependency in my build.gradle as a workaround to integrate Eureka and Spring Batch.

[spring-projects-issues]

Andy Wilkinson commented

For the record, Batch is the only project in the IO Platform that depends on Jettison so an upgrade to 1.3.x for 4.0 won't cause any problems elsewhere.

[spring-projects-issues]

Michael Minella commented

So some quick research on this seems as though upgrading isn't an option. Jettison is used to provide a HierarchicalStreamDriver for XStream for the XStreamExecutionContextStringSerializer in Spring Batch (https://github.com/spring-projects/spring-batch/blob/master/spring-batch-core/src/main/java/org/springframework/batch/core/repository/dao/XStreamExecutionContextStringSerializer.java#L68 ). The issue is that Jettison 1.3 isn't compatible with XStream (see x-stream/xstream#72). Given the current state of Jettison (barely maintained from what I can tell) and it's incompatibility with the current versions of XStream, I may look at ways to replace it all together.

Any opinions on the idea are appreciated.

[spring-projects-issues]

Michael Minella commented

It looks like the only way to drop Jettison all together would be to drop the XStreamExecutionContextStringSerializer. Given that it is the default serialization option for the ExecutionContext (and has been for many versions), that's a hard pill to swallow that fast. Right now I'm leaning towards switching the default serialization option in 4.0 to the Jackson2ExecutionContextStringSerialization option (a breaking change) and depricating the XStreamExecutionContextStringSerializer for future removal. This would at least allow for the dependency to become optional and allow users to override that decision while they transition.

The results of this decision will probably impact BATCH-2108 as well.

[spring-projects-issues]

Michael Minella commented

Resolved via 4ad0016

[spring-projects-issues]

Prateek commented

I am still not clear with the solution. Could you please provide code snippet what exactly needs to be added ? Better you can also answer here in detailed : https://stackoverflow.com/questions/49625231/migration-to-spring-boot-2-and-using-spring-batch-4/49636389#49636389.

This will really help new Spring Batch newbie like me. Looking forward for your response. 

[spring-projects-issues]

Sujay Purkayastha commented

Was this fixed only in 4.0.0, what about 3.0.8, 3.0.9?

[spring-projects-issues]

Sujay Purkayastha commented

Also, it seems that xstream is now an optional dependency with this change, what about Jettison itself? Do we still need the old version of Jettison 1.2?