GH-2452: Redeclare manual entities automatically #2453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-projects#2452 The queue might be declared manually by an `AmqpAdmin` and its name simply can be used in the listener container. When we lose a connection, we would like to have just deleted manual anonymous queue to be redeclared. * Introduce `AmqpAdmin.getManualDeclarables()` * Check for queue name presence in the `manualDeclarables` as well from a `AbstractMessageListenerContainer.attemptDeclarations()` * Modify `DirectMessageListenerContainerIntegrationTests.testRecoverDeletedQueueGuts()` to deal with manual declaration and auto-recovery from the container **Cherry-pick to `2.4.x`**
|
Feel free, Gary, just apply the change into a |
garyrussell
approved these changes
May 1, 2023
garyrussell
pushed a commit
that referenced
this pull request
May 1, 2023
Fixes #2452 The queue might be declared manually by an `AmqpAdmin` and its name simply can be used in the listener container. When we lose a connection, we would like to have just deleted manual anonymous queue to be redeclared. * Introduce `AmqpAdmin.getManualDeclarables()` * Check for queue name presence in the `manualDeclarables` as well from a `AbstractMessageListenerContainer.attemptDeclarations()` * Modify `DirectMessageListenerContainerIntegrationTests.testRecoverDeletedQueueGuts()` to deal with manual declaration and auto-recovery from the container **Cherry-pick to `2.4.x`**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2452
The queue might be declared manually by an
AmqpAdminand its name simply can be used in the listener container. When we lose a connection, we would like to have just deleted manual anonymous queue to be redeclared.AmqpAdmin.getManualDeclarables()manualDeclarablesas well from aAbstractMessageListenerContainer.attemptDeclarations()DirectMessageListenerContainerIntegrationTests.testRecoverDeletedQueueGuts()to deal with manual declaration and auto-recovery from the containerCherry-pick to
2.4.x