Run callback for shutdown also when container is already shut down #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is already shut down
artembilan
requested changes
Feb 3, 2023
| @@ -641,6 +641,9 @@ private void shutdownAndWaitOrCallback(@Nullable Runnable callback) { | |||
| } | |||
| else { | |||
| logger.info("Shutdown ignored - container is already stopped"); | |||
| if (callback != null) { | |||
| getTaskExecutor().execute(callback); | |||
There was a problem hiding this comment.
There is no reason to call this callback on a different thread.
Plus, take a look, please, there is one more return in this method where we have to take care about this callback, too.
There was a problem hiding this comment.
You are right! I will fix this and cover the other case as soon as I get around to work on this again.
artembilan
requested changes
Feb 7, 2023
...t/src/main/java/org/springframework/amqp/rabbit/listener/SimpleMessageListenerContainer.java
Show resolved
Hide resolved
|
... and cherry-picked to thank you for contribution; looking forward for more! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1561