Skip to content

AsyncMessageProcessingConsumer countdown when the container is not active #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 10, 2022

Conversation

renyansongno1
Copy link
Contributor

Resolves #1487

@pivotal-cla
Copy link

@renyansongno1 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@renyansongno1 Thank you for signing the Contributor License Agreement!

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there a chance to add some unit test to confirm the problem and the fix?

Thanks

@renyansongno1
Copy link
Contributor Author

@artembilan Hi, I have submitted the test code, please review.

@renyansongno1
Copy link
Contributor Author

@artembilan Thank you for your time!

@artembilan artembilan merged commit c67f80b into spring-projects:main Aug 10, 2022
@artembilan
Copy link
Member

... and cherry-picked to 2.4.x

@renyansongno1 ,

thank you very much for the contribution; looking forward for more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumer failed to start in XX milliseconds, SimpleMessageListenerContainer abnormal shut down
3 participants