Skip to content
This repository was archived by the owner on Mar 15, 2024. It is now read-only.

Return a client error when a nodeID is not found #34

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

harsimranmaan
Copy link
Contributor

@harsimranmaan harsimranmaan commented Mar 18, 2022

At present, if a client passes in an invalid ID to the /creds/[role]/[NodeID] endpoint, vault returns a 500

This change updates the error to be a 400 level return code

Other changes include updates for golang and deps

At present, if a client passes in an invalid ID to the /creds/<role>/<NodeID>  endpoint, vault returns a 500

This change updates the error to be a 400 level return code

Other changes include updates for golang and deps
@harsimranmaan harsimranmaan changed the title Use a client error when a nodeID is not found Return a client error when a nodeID is not found Mar 18, 2022
Copy link
Contributor

@michaelw michaelw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@michaelw michaelw merged commit c7308ea into splunk:master Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants