This repository was archived by the owner on Mar 15, 2024. It is now read-only.
Install golangci-lint #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhide
force-pushed
the
fix_lint
branch
3 times, most recently
from
438a307 to
0641181
Compare
michaelw
suggested changes
Aug 22, 2019
.circleci/config.yml
Outdated
| name: Code Quality | ||
| command: make lint | ||
| name: Install golangci-lint and check code Quality | ||
| command: curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.17.1 && make lint |
There was a problem hiding this comment.
let's not :)
we can download the script and commit it in a scripts/ dir, and then call it from here. at least we have an audit record of what it did.
also, why not add the download to "make dep"?
There was a problem hiding this comment.
Added to scripts directory. changed make lint to install golangci-lint.
circleci/golang:1.12 doesn't come with golangci-lint; install it as part of CI pipeline.
michaelw
approved these changes
Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
circleci/golang:1.12 doesn't come with golangci-lint; install it as part of CI pipeline.
Doing a
go getisn't recommeded for CI