Skip to content

Add matrix as a default dependency #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Add matrix as a default dependency #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ source "https://rubygems.org"
gemspec

gem "rubocop", require: false
gem "matrix"
gem "codeclimate-test-reporter"
1 change: 0 additions & 1 deletion gemfiles/7.0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ source "https://rubygems.org"
gem "rubocop", require: false
gem "codeclimate-test-reporter"
gem "rails", "~> 7.0"
gem "matrix"

gemspec path: "../"
10 changes: 1 addition & 9 deletions lib/split/algorithms.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,6 @@
# frozen_string_literal: true

begin
require "matrix"
rescue LoadError => error
if error.message.match?(/matrix/)
$stderr.puts "You don't have matrix installed in your application. Please add it to your Gemfile and run bundle install"
raise
end
end

require "matrix"
require "rubystats"

module Split
Expand Down
1 change: 1 addition & 0 deletions split.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Gem::Specification.new do |s|
s.add_dependency "redis", ">= 4.2"
s.add_dependency "sinatra", ">= 1.2.6"
s.add_dependency "rubystats", ">= 0.3.0"
s.add_dependency "matrix"

s.add_development_dependency "bundler", ">= 1.17"
s.add_development_dependency "simplecov", "~> 0.15"
Expand Down