Skip to content

Handle correctly case when ab_finished is called before ab_test for a user #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2019
Merged

Handle correctly case when ab_finished is called before ab_test for a user #577

merged 1 commit into from
Jul 6, 2019

Conversation

gnanou
Copy link
Contributor

@gnanou gnanou commented Jul 4, 2019

andrehjr
andrehjr approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@andrehjr andrehjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ thanks so much!

@andrehjr andrehjr merged commit 938de58 into splitrb:master Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrehjr andrehjr andrehjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug when ab_finished action takes place before the ab_test action
2 participants
@gnanou @andrehjr