Fix force_aleternative for experiments with incremented version
#568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andrehjr Please review this PR :) |
|
Sorry for taking so long. It's on my TODO list, will do it asap
…On Wed, Jun 12, 2019, 09:10 Takayuki Nakata ***@***.***> wrote:
@andrehjr <https://github.com/andrehjr> Please review this PR :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#568?email_source=notifications&email_token=AAAEEZIFWKIBG2I33SIFHZLP2DRSRA5CNFSM4HTYMUN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXQGJZQ#issuecomment-501245158>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAEEZKEQCONIYITMLYZH4TP2DRSRANCNFSM4HTYMUNQ>
.
|
|
Thanks for the reply. I got it :) |
andrehjr
approved these changes
Jun 13, 2019
|
Awesome! Thanks for the PR! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I closed #565, and resend this patch.
In dashboard,
force_alternativedoesn't work for experiments with incremented version to look for key without version.This PR fixes this issue and
force_alternativeworks for experiments with incremented version.Please review this.