Improve performance of RedisInterface#make_list_length by using LTRIM command #509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Redis
LTRIM
command docs here.Commit description:
A small improvement, but I happened to notice while looking around the code. Admittedly, it doesn't seem this method is currently used with a lot of data, but I think it's easy to imagine it having a significant impact on performance if used differently in the future.
I'd be happy to submit a benchmark if that would be helpful :).