Skip to content

Update toml dependency to 0.6 #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Update toml dependency to 0.6 #1052

merged 1 commit into from
Jan 26, 2023

Conversation

cardoso
Copy link
Contributor

@cardoso cardoso commented Jan 25, 2023

Opened a new PR to fix the commits ( cc @itowlson )

0.6 brings full TOML 1.0 compliance and several fixes.

Only had to adapt for a small breaking change:

de::from_slice and ser::to_vec were removed, instead use from_str and to_string and convert with bytes manually

https://github.com/toml-rs/toml/blob/main/crates/toml/CHANGELOG.md#060---2023-01-23

Also a few new features which could help with parsing and editing spin.toml

Signed-off-by: Matheus Cardoso [email protected]

Copy link
Collaborator

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@itowlson itowlson merged commit 51869c2 into spinframework:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants