Skip to content

chore(Cargo.toml): bump spin to v2.6.0 and wasmtime to 21.0.1; update usage #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

vdice
Copy link
Contributor

@vdice vdice commented Jun 20, 2024

@vdice vdice force-pushed the chore/bump-spin-and-wasmtime branch 3 times, most recently from 9876b67 to bc1f3bc Compare June 20, 2024 19:45
@vdice vdice force-pushed the chore/bump-spin-and-wasmtime branch 2 times, most recently from db02e49 to 42f984e Compare June 20, 2024 19:55
@vdice
Copy link
Contributor Author

vdice commented Jun 20, 2024

How is the sample app in this repo run/tested?

First attempt yields:

$ spin up
Warning: You're using a pre-release version of Spin (2.7.0-pre0). This plugin might not be compatible (supported: >=2.0). Continuing anyway.
Logging component stdio to ".spin/logs/"
2024-06-20T21:08:04.418205Z ERROR spin_trigger::cli: Trigger executor failed
Error: Wasi preview 2 components need to target the wasi:cli world

Caused by:
    exported instance `wasi:cli/[email protected]` not present
    ```

@itowlson
Copy link

@vdice Are you on a recent version of cargo component? What does wasm-tools component wit tell you about the Wasm file?

@vdice
Copy link
Contributor Author

vdice commented Jun 20, 2024

@itowlson that was it, thank you! I was on a much earlier version of cargo component. @kate-goldenring helped determine this was the cause. I can now build and run the sample app 🚀

Copy link
Contributor

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should bump the spin-pluginify.toml before the release

@vdice vdice force-pushed the chore/bump-spin-and-wasmtime branch from 42f984e to 305b326 Compare June 20, 2024 23:58
@vdice vdice merged commit 87a514e into spinframework:main Jun 21, 2024
8 checks passed
@vdice vdice deleted the chore/bump-spin-and-wasmtime branch June 21, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants