-
Notifications
You must be signed in to change notification settings - Fork 13
WIP: add support for preview 2 components that target the wasi:cli world #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: karthik2804 <[email protected]>
Can we infer |
We can attempt to load as a component and fall back to a module. I just tested it locally, and it appears to work as expected. |
ac5b94c
to
3db30cd
Compare
Signed-off-by: karthik2804 <[email protected]>
3db30cd
to
ba740df
Compare
spin-app = { git = "https://github.com/fermyon/spin", tag = "v2.3.1" } | ||
spin-core = { git = "https://github.com/fermyon/spin", tag = "v2.3.1" } | ||
spin-trigger = { git = "https://github.com/fermyon/spin", tag = "v2.3.1" } | ||
spin-app = { git = "https://github.com/fermyon/spin" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: leave a TODO to pin to the Spin 2.4
release for these dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to pin to 2.4?
I pinned to 2.3.1 earlier so this can be imported in the containerd shim.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point and probably necessitates implementing this in terms of what's available in 2.3.1.
I only noticed the upgrade to the various new traits used below that will be made available in 2.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These can definitely be implemented pinned to 2.3.1
but I upgraded as I was following the example of the http-trigger
. Do we think pinning it to 2.3.1 is a necessity or will the shim be updated to 2.4.0
once that is released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll bump everything once 2.4 is out.
Signed-off-by: karthik2804 <[email protected]>
Tested this with both Preview 1 and Preview 2 components and everything looks good. Merging so we can iterate. Thanks! |
This adds a field to the trigger similar to the http-trigger that needs to be set if runningpreview1
components.This PR adds the ability for the trigger to support preview 2 components along with modules as well. It does it by attempting to load things as a component but falling back to attempting to load modules. The one other constraint it includes is that any preview 2 component supplied must target the
wasi:cli
world.