Spin 3.4 SQLite and PostgreSQL interfaces #81
Conversation
Signed-off-by: itowlson <[email protected]>
|
Because the new code feature-gates several functions and implementations, I added a couple of GH checks to make sure I hadn't messed up the gating. (I had. Of course I had.) These turned up a couple of errors with |
Signed-off-by: itowlson <[email protected]>
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
spin-3.4-interfaces
branch
from
a4378b2 to
44350d6
Compare
Signed-off-by: itowlson <[email protected]>
itowlson
force-pushed
the
spin-3.4-interfaces
branch
from
cb606c3 to
978a1b3
Compare
Signed-off-by: itowlson <[email protected]>
itowlson
added
the
v-next
| /// # } | ||
| /// ``` | ||
| #[doc(inline)] | ||
| pub use super::wit::pg4::Connection; |
There was a problem hiding this comment.
We extend the equivalent type in sqlite3: https://github.com/spinframework/spin-rust-sdk/pull/81/files#diff-5d6f50ac9a55cf5e3cd0473391b4195d9aed79c7bd7d2e896c6124b70e8a4416R184-R199
Do we not want the same thing here?
There was a problem hiding this comment.
Ther's no concept of default for Postgres databases (Spin doesn't provide an implementation - it's address-based rather than label-based).
There was a problem hiding this comment.
That's true, but the rows method does seem like it would be useful, no?
| } | ||
| } | ||
|
|
||
| impl Decode for bool { |
There was a problem hiding this comment.
A macro to generate the impls for all of these primitive types might make things easier to read 🤷
There was a problem hiding this comment.
How strongly do you feel about doing that as part of this PR? The code here follows pg/pg3: I like the idea of a macro but I assume we'd prefer to apply it across all versions (or all versions that we retain).
There was a problem hiding this comment.
I don't feel strongly about this. Just a thought.
itowlson
removed
the
v-next
Fixes #79 and #80
Draft for now because:
Make deps opt-out, and make new code appropriately conditional:Figure out a solution for decodingIt's a horrible solution. But here we areNUMERICRANGETestingunits, and example works on my machineExamplesI did one for ranges which are the trap, can do more if suitably motivatedCheck documentationDocument workaround for range query grammar ambiguityNew database APIs for Spin 3.4 spin-docs#119