Skip to content

Conversation

@lou-lan
Copy link
Collaborator

@lou-lan lou-lan commented Sep 23, 2025

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #

Special notes for your reviewer:

Release note:

Added support for specifying custom container runtime network namespace paths for RDMA metrics collection.

@lou-lan lou-lan changed the base branch from main to release-v1.0 September 23, 2025 11:41
@lou-lan lou-lan changed the title Cherry pick Add custom runtime netns path Sep 23, 2025
@lou-lan lou-lan added the release/feature-new release note for new feature label Sep 23, 2025
@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 74.84277% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.44%. Comparing base (86681a3) to head (c54be01).
⚠️ Report is 2 commits behind head on release-v1.0.

Files with missing lines Patch % Lines
pkg/rdmametrics/metrics.go 75.39% 19 Missing and 12 partials ⚠️
pkg/rdmametrics/tos.go 72.72% 6 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v1.0    #5175      +/-   ##
================================================
- Coverage         78.73%   78.44%   -0.30%     
================================================
  Files                55       56       +1     
  Lines              6541     6545       +4     
================================================
- Hits               5150     5134      -16     
- Misses             1176     1187      +11     
- Partials            215      224       +9     
Flag Coverage Δ
unittests 78.44% <74.84%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/rdmametrics/tos.go 72.72% <72.72%> (ø)
pkg/rdmametrics/metrics.go 74.79% <75.39%> (-4.70%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@weizhoublue weizhoublue merged commit fde36fa into release-v1.0 Sep 24, 2025
48 of 53 checks passed
@weizhoublue weizhoublue deleted the cherry-pick branch September 24, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/feature-new release note for new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants