Skip to content

Conversation

@cyclinder
Copy link
Collaborator

…onses

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #5049

Special notes for your reviewer:

Release note:


@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.85%. Comparing base (9bf2d04) to head (e00c384).
⚠️ Report is 1 commits behind head on release-v1.0.

Files with missing lines Patch % Lines
cmd/spiderpool/cmd/command_add.go 0.00% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v1.0    #5066      +/-   ##
================================================
+ Coverage         75.43%   78.85%   +3.41%     
================================================
  Files                56       55       -1     
  Lines              6856     6536     -320     
================================================
- Hits               5172     5154      -18     
+ Misses             1470     1166     -304     
- Partials            214      216       +2     
Flag Coverage Δ
unittests 78.85% <0.00%> (+3.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/spiderpool/cmd/cni_types.go 100.00% <ø> (ø)
cmd/spiderpool/cmd/command_add.go 68.25% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cyclinder cyclinder merged commit 317647c into spidernet-io:release-v1.0 Aug 19, 2025
48 of 55 checks passed
@cyclinder cyclinder deleted the cp_1.0/ipam_fix_detection branch August 19, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant