Skip to content

Conversation

@cyclinder
Copy link
Collaborator

@cyclinder cyclinder commented Jun 30, 2025

Thanks for contributing!

Notice:

What issue(s) does this PR fix:

Fixes #

Special notes for your reviewer:

cherry-pick #4675 to release-v1.0

Release note:


@cyclinder cyclinder added release/feature-changed release note for changed feature release-v1.0 labels Jun 30, 2025
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.74%. Comparing base (a0b6624) to head (12cc6db).
Report is 1 commits behind head on release-v1.0.

Files with missing lines Patch % Lines
pkg/podmanager/pod_webhook.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-v1.0    #4974      +/-   ##
================================================
+ Coverage         75.21%   75.74%   +0.53%     
================================================
  Files                56       56              
  Lines              6818     6856      +38     
================================================
+ Hits               5128     5193      +65     
+ Misses             1475     1444      -31     
- Partials            215      219       +4     
Flag Coverage Δ
unittests 75.74% <88.37%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/ippoolmanager/ippool_webhook.go 90.62% <100.00%> (+2.31%) ⬆️
pkg/subnetmanager/subnet_webhook.go 90.62% <100.00%> (+2.31%) ⬆️
pkg/podmanager/pod_webhook.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cyclinder cyclinder merged commit 9bf2d04 into spidernet-io:release-v1.0 Jun 30, 2025
51 of 55 checks passed
@cyclinder cyclinder deleted the cp_1.0/webhook_delete_ippool branch June 30, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/feature-changed release note for changed feature release-v1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant