Skip to content

fix: retrieve the endpoint for deleted stateless pod #4733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weizhoublue merged 1 commit into from
Mar 11, 2025
Merged

fix: retrieve the endpoint for deleted stateless pod #4733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/gcmanager/scanAll_IPPool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,8 @@ func (s *SpiderGC) executeScanAll(ctx context.Context) {
flagStaticIPPod := false
endpoint, endpointErr := s.wepMgr.GetEndpointByName(ctx, podNS, podName, constant.UseCache)
podYaml, podErr := s.podMgr.GetPodByName(ctx, podNS, podName, constant.UseCache)

// handle the pod not existed with the same name
if podErr != nil {
// case: The pod in IPPool's ip-allocationDetail is not exist in k8s
if apierrors.IsNotFound(podErr) {
Expand Down Expand Up @@ -168,6 +170,7 @@ func (s *SpiderGC) executeScanAll(ctx context.Context) {
continue
}

// check the pod status
switch {
case podYaml.Status.Phase == corev1.PodSucceeded || podYaml.Status.Phase == corev1.PodFailed:
wrappedLog := scanAllLogger.With(zap.String("gc-reason", fmt.Sprintf("The current state of the Pod %s/%s is: %v", podNS, podName, podYaml.Status.Phase)))
Expand Down Expand Up @@ -263,7 +266,7 @@ func (s *SpiderGC) executeScanAll(ctx context.Context) {
}
}

// handle the IP in ippool
// handle same name pod with different uid in the ippool
if string(podYaml.UID) != poolIPAllocation.PodUID {
wrappedLog := scanAllLogger.With(zap.String("gc-reason", fmt.Sprintf("Pod: %s/%s UID %s is different from IPPool: %s UID %s", podNS, podName, podYaml.UID, pool.Name, poolIPAllocation.PodUID)))
if flagStaticIPPod {
Expand Down Expand Up @@ -311,6 +314,7 @@ func (s *SpiderGC) executeScanAll(ctx context.Context) {
flagGCEndpoint = false
}
} else {
// handle same name pod with different uid in the endpoint
if string(podYaml.UID) != endpoint.Status.Current.UID {
wrappedLog := scanAllLogger.With(zap.String("gc-reason", fmt.Sprintf("Pod:%s/%s UID %s is different from endpoint:%s/%s UID %s", podNS, podName, podYaml.UID, endpoint.Namespace, endpoint.Name, poolIPAllocation.PodUID)))
if flagStaticIPPod {
Expand All @@ -337,6 +341,7 @@ func (s *SpiderGC) executeScanAll(ctx context.Context) {
} else {
wrappedLog.Sugar().Infof("pod %s/%s is not a static Pod with a status of %v, the endpoint %v/%v should be reclaimed", podNS, podName, podYaml.Status.Phase, endpoint.Namespace, endpoint.Name)
flagGCIPPoolIP = true
flagGCEndpoint = true
}
} else {
if flagPodStatusShouldGCIP {
Expand Down
Loading