Skip to content

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 21, 2024

Feature or Bugfix

  • Feature

Purpose

  • Add versionremoved directive, for when removing features.
  • Similar to existing versionadded, versionchanged, and deprecated.

Relates

Copy link
Contributor

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a maintainer here ofc, and personally I'm working on a suite of much more capable directives to replace the upstream builtin version* suite with CPython's deprecated-removed as a basis (which more or less already replaces this), but it seems eminently sensible and straightforward, IMO, to add a versionremoved to the base suite to parallel the others. A few minor comments.

hugovk and others added 2 commits January 21, 2024 12:14
@AA-Turner AA-Turner merged commit 95b2cce into sphinx-doc:master Jan 21, 2024
@AA-Turner
Copy link
Member

Thanks!

@hugovk hugovk deleted the add-versionremoved branch January 21, 2024 20:18
@CAM-Gerlach
Copy link
Contributor

Thanks @AA-Turner !

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
@AA-Turner AA-Turner added this to the 7.3.0 milestone Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add versionremoved directive to complement versionadded and deprecated

4 participants