Skip to content

Update command.go #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marckhouzam merged 1 commit into from
Mar 7, 2025
Merged

Update command.go #2248

marckhouzam merged 1 commit into from
Mar 7, 2025
+1 −1

Conversation

@styee
Copy link
Contributor

@styee styee commented Mar 5, 2025

Fix spelling in the help output.

topcis -> topics

@styee
Update command.go
dca1d08 
Fix spelling in the help output.

topcis -> topics
@CLAassistant
Copy link

CLAassistant commented Mar 5, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

marckhouzam
marckhouzam approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t believe I missed that 😞
Thanks for fixing it.
The additional help topics are very rarely used so I’m hoping this won’t require a patch release. How do you feel about it @styee ?

@marckhouzam marckhouzam merged commit 4f9ef8c into spf13:main Mar 7, 2025
22 checks passed
@marckhouzam marckhouzam added this to the 1.10.0 milestone Mar 7, 2025
@styee
Copy link
Contributor Author

styee commented Mar 7, 2025

Thanks! Very likely nobody has noticed to this point, I don't think it needs a patch release.

@stasadev stasadev mentioned this pull request Jun 9, 2025
Closed
@caarlos0
Copy link
Collaborator

caarlos0 commented Jun 26, 2025

Thanks! Very likely nobody has noticed to this point, I don't think it needs a patch release.

Thanks! Very likely nobody has noticed to this point, I don't think it needs a patch release.

I did! hehe
Is it possible to cut a patch with this?

@marckhouzam
Copy link
Collaborator

marckhouzam commented Jun 26, 2025

Cutting a new release is not a big deal from the cobra side. It’s just that it might have so many projects feel like they have to look into the new release that I’m hesitant to do small ones like this.
cc @jpmcb

@caarlos0 would you be able to just use the latest main branch for the moment?

@caarlos0
Copy link
Collaborator

caarlos0 commented Jun 26, 2025

yes, no worries :)

project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-runner that referenced this pull request Sep 1, 2025
@viceice-bot
Update module github.com/spf13/cobra to v1.10.1 (#930)
3235542 
This PR contains the following updates:

| Package | Change | Age | Confidence |
|---|---|---|---|
| [github.com/spf13/cobra](https://github.com/spf13/cobra) | `v1.9.1` -> `v1.10.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fspf13%2fcobra/v1.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fspf13%2fcobra/v1.9.1/v1.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>spf13/cobra (github.com/spf13/cobra)</summary>

### [`v1.10.1`](https://github.com/spf13/cobra/releases/tag/v1.10.1)

[Compare Source](spf13/cobra@v1.10.0...v1.10.1)

##### 🐛 Fix

- chore: upgrade pflags v1.0.9 by [@&#8203;jpmcb](https://github.com/jpmcb) in [#&#8203;2305](spf13/cobra#2305)

v1.0.9 of pflags brought back `ParseErrorsWhitelist` and marked it as deprecated

**Full Changelog**: <spf13/cobra@v1.10.0...v1.10.1>

### [`v1.10.0`](https://github.com/spf13/cobra/releases/tag/v1.10.0)

[Compare Source](spf13/cobra@v1.9.1...v1.10.0)

#### What's Changed

##### 🚨 Attention!

- Bump pflag to 1.0.8 by [@&#8203;tomasaschan](https://github.com/tomasaschan) in [#&#8203;2303](spf13/cobra#2303)

This version of `pflag` carried a breaking change: it renamed `ParseErrorsWhitelist` to `ParseErrorsAllowlist` which can break builds if both `pflag` and `cobra` are dependencies in your project.

- If you use both `pflag and `cobra`, upgrade `pflag`to 1.0.8 and`cobra`to`1.10.0\`
- ***or*** use the newer, fixed version of `pflag` v1.0.9 which keeps the deprecated `ParseErrorsWhitelist`

More details can be found here: [#&#8203;2303 (comment)](spf13/cobra#2303 (comment))

##### ✨ Features

- Flow context to command in SetHelpFunc by [@&#8203;Frassle](https://github.com/Frassle) in [#&#8203;2241](spf13/cobra#2241)
- The default ShellCompDirective can be customized for a command and its subcommands by [@&#8203;albers](https://github.com/albers) in [#&#8203;2238](spf13/cobra#2238)

##### 🐛 Fix

- Upgrade golangci-lint to v2, address findings by [@&#8203;scop](https://github.com/scop) in [#&#8203;2279](spf13/cobra#2279)

##### 🪠 Testing

- Test with Go 1.24 by [@&#8203;harryzcy](https://github.com/harryzcy) in [#&#8203;2236](spf13/cobra#2236)
- chore: Rm GitHub Action PR size labeler by [@&#8203;jpmcb](https://github.com/jpmcb) in [#&#8203;2256](spf13/cobra#2256)

##### 📝 Docs

- Remove traling curlybrace by [@&#8203;yedayak](https://github.com/yedayak) in [#&#8203;2237](spf13/cobra#2237)
- Update command.go by [@&#8203;styee](https://github.com/styee) in [#&#8203;2248](spf13/cobra#2248)
- feat: Add security policy by [@&#8203;jpmcb](https://github.com/jpmcb) in [#&#8203;2253](spf13/cobra#2253)
- Update Readme (Warp) by [@&#8203;ericdachen](https://github.com/ericdachen) in [#&#8203;2267](spf13/cobra#2267)
- Add Periscope to the list of projects using Cobra by [@&#8203;anishathalye](https://github.com/anishathalye) in [#&#8203;2299](spf13/cobra#2299)

#### New Contributors

- [@&#8203;harryzcy](https://github.com/harryzcy) made their first contribution in [#&#8203;2236](spf13/cobra#2236)
- [@&#8203;yedayak](https://github.com/yedayak) made their first contribution in [#&#8203;2237](spf13/cobra#2237)
- [@&#8203;Frassle](https://github.com/Frassle) made their first contribution in [#&#8203;2241](spf13/cobra#2241)
- [@&#8203;styee](https://github.com/styee) made their first contribution in [#&#8203;2248](spf13/cobra#2248)
- [@&#8203;ericdachen](https://github.com/ericdachen) made their first contribution in [#&#8203;2267](spf13/cobra#2267)
- [@&#8203;albers](https://github.com/albers) made their first contribution in [#&#8203;2238](spf13/cobra#2238)
- [@&#8203;anishathalye](https://github.com/anishathalye) made their first contribution in [#&#8203;2299](spf13/cobra#2299)
- [@&#8203;tomasaschan](https://github.com/tomasaschan) made their first contribution in [#&#8203;2303](spf13/cobra#2303)

**Full Changelog**: <spf13/cobra@v1.9.1...v1.9.2>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45MS4yIiwidXBkYXRlZEluVmVyIjoiNDEuOTEuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiS2luZC9DaG9yZSIsInJ1bi1lbmQtdG8tZW5kLXRlc3RzIl19-->

<!--start release-notes-assistant-->
<!--URL:https://code.forgejo.org/forgejo/runner-->
- other
  - [PR](https://code.forgejo.org/forgejo/runner/pulls/930): <!--number 930 --><!--line 0 --><!--description VXBkYXRlIG1vZHVsZSBnaXRodWIuY29tL3NwZjEzL2NvYnJhIHRvIHYxLjEwLjE=-->Update module github.com/spf13/cobra to v1.10.1<!--description-->
<!--end release-notes-assistant-->

Reviewed-on: https://code.forgejo.org/forgejo/runner/pulls/930
Reviewed-by: earl-warren <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-committed-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marckhouzam marckhouzam marckhouzam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.10.0

Development

Successfully merging this pull request may close these issues.

4 participants

@styee @CLAassistant @caarlos0 @marckhouzam