Micro-optimizations #1957
Merged
Micro-optimizations #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks @scop ! |
There likely isn't actually more than once to split in the source strings in these cases, but avoid doing so anyway as we're only interested in the first.
The target is not to be changed while outputting completions, so resolve it only once.
The enablement state is not to be changed during completion output, so evaluate it only once.
Contributor
Author
|
Rebased and added some more. |
marckhouzam
approved these changes
Nov 4, 2023
Collaborator
marckhouzam
left a comment
marckhouzam
left a comment
There was a problem hiding this comment.
LGTM
But I’m not near a computer right now so I’ll wait until I can test it to merge.
@jpmcb if you’re comfortable merging, go right ahead
marckhouzam
added
kind/cleanup
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while looking into something else. No benchmarks/numbers done, but even if this wouldn't yield measurable improvements, the changes don't hurt readability IMO and actually in a sense they convey the intent better.