Enhance the style of the checkboxes for multi-selection #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
I truly hope this gets merged, it's truly painful for designing that the color isn't matching. |
|
Thansk @SypherrDev, I'm waiting for someone review to be able to complete these PR. 😃 |
|
@patriksvensson aligned also this branch to the last commit in main. |
|
@davide-pi Could you perfom a rebase on your branch instead of a merge as per our CONTRIBUTING.md instructions? |
…he selected style, if available, to the checkboxes that are currently selected. # Conflicts: # src/Spectre.Console/Prompts/List/ListPromptConstants.cs
|
Sure sorry @patriksvensson. Fixed with the rebase, thanks! |
patriksvensson
approved these changes
Sep 9, 2024
This was referenced Jul 22, 2025
This was referenced Jul 30, 2025
This was referenced Aug 6, 2025
This was referenced Aug 15, 2025
This was referenced Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance the style of the checkboxes for multi-selection by applying the selected style, if available, to the checkboxes that are currently selected.
Examples
Old or without style specified
With multiselection style specified with
.HighlightStyle(new Style(Color.Red))Reason
I would like the
Xon the selected checkboxes to have the same style as the multiselection highlight to avoid any mismatched color combinationsPlease upvote 👍 this pull request if you are interested in it.