Skip to content

Conversation

koizumistr
Copy link

No description provided.

koizumistr and others added 7 commits October 21, 2024 23:30
@bact bact added the translation: ja Translation for Japanese language label Oct 22, 2024
@bact
Copy link
Collaborator

bact commented Oct 25, 2024

The addition of translated files are looking good.

The only warning, which made the check failed, is about the inclusion of those files in nav section of mkdocs.yml.
This needs more discussion later on how we like to deal with it (it is likely that we may need one MkDocs configuration per one language?)
But for now I think this PR is good to merge (and we can improve upon afterward). The translation files themselves are good.

The only question I have in mind now is which branch this PR should merge to?

@bact
Copy link
Collaborator

bact commented Jan 15, 2025

This should be retarget to merge to support/3.0 branch

@bact
Copy link
Collaborator

bact commented Apr 1, 2025

Currently the workflow shows below error because it does not know how to handle translation files:

WARNING -  The following pages exist in the docs directory, but are not included in the "nav" configuration:
  - ja/index.md
  - ja/scope.md
  - ja/annexes/spdx-lite.md
  - ja/front/copyright.md
  - ja/front/introduction.md
  - ja/licenses/CC-BY-3.0.md
  - ja/licenses/Community-Spec-1.0.md

These files are expected to be handled by the MkDocs internationalization plugin. (Not something that can be fixed directly in this PR alone. Need a rework in publication workflow)

@bact bact added this to the 3.0.1 milestone Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation: ja Translation for Japanese language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants