General code health improvements #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also the model is not nullable at this point, so we can safely remove the null-safe operator below the if condition.
|
Hey @xHeaven! Thanks for the PR. You spotted a couple nice fixes. |
|
Hey @AlexVanderbist is there a plan to release this? It wasn't included in 6.3.0, and there haven't been any releases yet this year (Appreciate the holidays in the middle 😅) We've recently upgraded to PHP 8.4 and are now dealing with deprecation warnings, which are fixed by this PR. Thanks in advance 😄 |
|
I've tagged a new release that includes these fixes now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AllowedFilterconstructor, but wasn't actually used because there is no such parameter in thereIt looks kind of a lot, but it really is not much, there is no breaking or functional change whatsoever. Hope it can go in.