Skip to content

Add assign-role command #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sediqzada94
Copy link

πŸ†• Add Artisan Command to Assign Roles to Users

πŸ“Œ Description

This PR adds a new Artisan command permission:assign-role that simplifies the process of assigning roles to users via the CLI.


πŸ› οΈ Command Signature

php artisan permission:assign-role {name} {userId} {guard?} {userModelNamespace=App\Models\User}

@zigzagdev
Copy link

@sediqzada94

Hi ! πŸ‘‹

I'm not this repository maintainer but leave a note i noticed.

Since guard is defined as an optional argument here ({guard?}),
there’s a possibility that $guardName becomes null when not specified.
This may cause unexpected behavior in findOrCreate() as it would query for guard_name = null,
which can result in an incorrect role lookup or creation.

You might want to fallback to the default guard like this:

$guardName = $this->argument('guard') ?? config('auth.defaults.guard');

The config part here is just an example, and you should adjust it based on your application's specific requirements.

@parallels999
Copy link
Contributor

Also not taking into account the "Teams feature"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants