-
Notifications
You must be signed in to change notification settings - Fork 26
JP-3307: Add metadata keywords to schema for ta_center step #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
==========================================
+ Coverage 90.32% 90.33% +0.01%
==========================================
Files 99 99
Lines 4674 4679 +5
==========================================
+ Hits 4222 4227 +5
Misses 452 452 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
regtests with jwst main: https://github.com/spacetelescope/RegressionTests/actions/runs/19579002977 regtests with jwst PR branch: https://github.com/spacetelescope/RegressionTests/actions/runs/19578975714 |
|
regtest rerun against main: https://github.com/spacetelescope/RegressionTests/actions/runs/19689393898 Differences are expected: they add SRCXPOS and SRCYPOS keywords to MIRI LRS slit and slitless data only |
|
New regtest runs, which don't add metadata to the ImageModel and CubeModel because we're going to use SlitModel for MIRI LRS now, show no differences: |
|
@melanieclarke all three comments should be addressed by d4027da |
|
This all looks good now, thanks! I'm reviewing the jwst PR now, though, so let's leave this one open for a bit in case there are further changes needed. |
Part of JP-3307
Is blocked by spacetelescope/jwst#10035This PR adds the
cal_stepstatus for the newtarg_centroidstep, addssource_xposandsource_yposheader keywords to store the results of that step, and addsta_xpos,ta_yposkeywords to store the "true" position of the source in the TA verification image (prior to applying filteroffset)See spacetelescope/jwst#10011
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)jwstregression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")news fragment change types...
changes/<PR#>.feature.rst: new featurechanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.removal.rst: deprecation or removal of public APIchanges/<PR#>.misc.rst: infrastructure or miscellaneous change