Skip to content

Conversation

@emolter
Copy link
Contributor

@emolter emolter commented Nov 20, 2025

Part of JP-3307

Is blocked by spacetelescope/jwst#10035

This PR adds the cal_step status for the new targ_centroid step, adds source_xpos and source_ypos header keywords to store the results of that step, and adds ta_xpos, ta_ypos keywords to store the "true" position of the source in the TA verification image (prior to applying filteroffset)

See spacetelescope/jwst#10011

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.33%. Comparing base (dcea963) to head (1818c4c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   90.32%   90.33%   +0.01%     
==========================================
  Files          99       99              
  Lines        4674     4679       +5     
==========================================
+ Hits         4222     4227       +5     
  Misses        452      452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emolter
Copy link
Contributor Author

emolter commented Nov 21, 2025

@emolter
Copy link
Contributor Author

emolter commented Nov 26, 2025

regtest rerun against main: https://github.com/spacetelescope/RegressionTests/actions/runs/19689393898

Differences are expected: they add SRCXPOS and SRCYPOS keywords to MIRI LRS slit and slitless data only

@emolter emolter marked this pull request as ready for review November 26, 2025 16:04
@emolter emolter requested a review from a team as a code owner November 26, 2025 16:04
@emolter
Copy link
Contributor Author

emolter commented Dec 12, 2025

New regtest runs, which don't add metadata to the ImageModel and CubeModel because we're going to use SlitModel for MIRI LRS now, show no differences:
https://github.com/spacetelescope/RegressionTests/actions/runs/19689393898

@emolter
Copy link
Contributor Author

emolter commented Dec 15, 2025

@melanieclarke all three comments should be addressed by d4027da

@melanieclarke
Copy link
Contributor

This all looks good now, thanks! I'm reviewing the jwst PR now, though, so let's leave this one open for a bit in case there are further changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants