JP-2572: Updating the handler for the suppression of one good group ramps. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 90.13% 90.15% +0.02%
==========================================
Files 16 16
Lines 2433 2438 +5
==========================================
+ Hits 2193 2198 +5
Misses 240 240
Continue to review full report at Codecov.
|
dmggh
approved these changes
May 20, 2022
Contributor
dmggh
left a comment
dmggh
left a comment
There was a problem hiding this comment.
Aside from 2 minor comments, looks good.
cshanahan1
approved these changes
May 20, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the possibility the first groups of a ramp could be flagged as DO_NOT_USE, as well as the way the jump detector works, the one good group suppression handler needed to be modified to handle these cases as well.