Skip to content

Conversation

@pllim
Copy link
Contributor

@pllim pllim commented Nov 19, 2025

Resolves JP-3964

Closes #441

This PR allows get_catalog to filter out rows with bad proper motion info. This would be the new default behavior. ref spacetelescope/jwst#8168

Might get superseded by https://jira.stsci.edu/browse/AL-1006 anyway in the future.

TODO

  • Buy-in from INS; they have to find edge cases and perform science case testing, etc.
  • Are romancal RT failures acceptable? Eddie and/or Mihai should review.

Tasks

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.22%. Comparing base (3c76759) to head (722fc9c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
+ Coverage   90.10%   90.22%   +0.12%     
==========================================
  Files          65       65              
  Lines       10315    10344      +29     
==========================================
+ Hits         9294     9333      +39     
+ Misses       1021     1011      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim
Copy link
Contributor Author

pllim commented Nov 19, 2025

I'll keep this in draft form until we have buy-in from INS. FYI.

@pllim pllim force-pushed the tweak-and-shout-less branch from 2320048 to 8194be8 Compare November 26, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants