Skip to content

Conversation

@kmacdonald-stsci
Copy link
Collaborator

Resolves JP-4000

This PR is a first pass at addressing persistence flagging for large events. A persistence flag and an optional persistence file name parameter has been added to the jump_data class in the jump step. With default settings this will not affect the current processing of the jump step.

These parameters allow for persistence flagging when the persistence flag is set to True. If a persistence file name is passed, the file is opened and a 2-D uint8 array is retrieved to be or'd into each group. If a file name is not passed, a 2-D uint8 array is created and populated from the first integration, which persists through all subsequent integrations.

Currently, these changes will not affect JWST processing and are not accessible from that pipeline. To access these options, the JumpData class needs to be directly modified and the jump function in STCAL jump module called.

Tests have not been developed, yet.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@github-actions github-actions bot added the jump label Oct 28, 2025
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.60%. Comparing base (004546e) to head (747ee32).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/stcal/jump/jump.py 30.76% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
- Coverage   89.71%   89.60%   -0.11%     
==========================================
  Files          67       67              
  Lines       10431    10446      +15     
==========================================
+ Hits         9358     9360       +2     
- Misses       1073     1086      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant