-
Notifications
You must be signed in to change notification settings - Fork 35
Rescale resample kernels by pixel scale ratio - V2 #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rescale resample kernels by pixel scale ratio - V2 #418
Conversation
braingram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just marking a requested change for the dependency change so we don't commit a git dependency to main.
| dependencies = [ | ||
| "astropy >=6.0.0", | ||
| "drizzle >=2.0.1", | ||
| "drizzle@git+https://github.com/mcara/drizzle.git@decouple-scales", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "drizzle@git+https://github.com/mcara/drizzle.git@decouple-scales", | |
| "drizzle >= 2.2.0, <3", |
I'm going to mark this as a requested change as a reminder that this needs to be update prior to merge so we don't introduce a git dependency here. What version of drizzle will have iscale?
For the drizzle API changes, we'll need to work out how this will:
- impact jwst which pins to
<2.2.0 - impact romancal which has only a lower pin for
>2.1.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking version 3 since it will include major enhancements like drizzling variance arrays for error propagation (although not used in our pipelines)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 89.71% 89.25% -0.46%
==========================================
Files 67 67
Lines 10431 10437 +6
==========================================
- Hits 9358 9316 -42
- Misses 1073 1121 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolves JP-4137
Closes #412
This PR fixes a bug in the resample code which is caused by the fact that we fix the
iscaleto be 1 whiledrizzleuses it in some kernels (turbo, gaussian, and lanczos) not only to apply a scale to input image data but also to compute kernel size in the input image frame from sizes in output image (that is,drizzleexpects it to be pixel scale ratio).This PR takes a different approach from #412:
iscaleand (old)kscale(nowpixel_scale_ratio) have been decoupled in spacetelescope/drizzle#203 and this PR makes necessary code changes instcalto work with the upcomingdrizzlerelease that will include spacetelescope/drizzle#203Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)"git+https://github.com/<fork>/stcal@<branch>")jwstregression testromancalregression testnews fragment change types...
changes/<PR#>.apichange.rst: change to public APIchanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.general.rst: infrastructure or miscellaneous change