JP-3164: Update STCAL CI Tests #362
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 88.02% 89.74% +1.71%
==========================================
Files 64 64
Lines 9983 9965 -18
==========================================
+ Hits 8788 8943 +155
+ Misses 1195 1022 -173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tapastro
reviewed
Apr 15, 2025
|
|
||
| # Make sure that groups after the third get flagged | ||
| assert np.all(gdq[0, 2:, 5, 5] == DQFLAGS["SATURATED"]) | ||
| assert np.all(gdq[0, 3:, 5, 5] == DQFLAGS["SATURATED"]) |
Collaborator
There was a problem hiding this comment.
I think the behavior introduced by #321 is not desirable long term; if we opt to remove the xfail here, we should at least add a comment describing the ideal state for future edits to the code and this test. I believe the long-term fix will be tracked under https://jira.stsci.edu/browse/JP-3835
emolter
reviewed
Apr 17, 2025
Collaborator
emolter
left a comment
emolter
left a comment
There was a problem hiding this comment.
Overall these look good to me Ken, but what is the status of
stcal/tests/test_ramp_fitting_gls_fit.py
Line 196 in b4131aa
pllim
added a commit
to pllim/stcal
that referenced
this pull request
Dec 15, 2025
and fix tests. MNT: Add __all__ to ramp_fitting/utils.py DOC: Fix DQ propagation text. TST: Un-xfail test_read_pattern_saturation_flagging from spacetelescope#362
pllim
reviewed
Dec 15, 2025
| assert np.all(gdq[0, 2:, 5, 5] == DQFLAGS["SATURATED"]) | ||
| # XXX - PR #321 introduced this behavior, but it may not be what's wanted. For now | ||
| # the xfail has been removed to test the current behavior. | ||
| assert np.all(gdq[0, 3:, 5, 5] == DQFLAGS["SATURATED"]) |
Contributor
There was a problem hiding this comment.
I caught this one separately at #421 so I copied this part of the PR over to my PR there. FYI.
melanieclarke
pushed a commit
that referenced
this pull request
Dec 18, 2025
…pagated to the _rate DQ (#421) * JP-3967: SATURATION flag for partially saturated pixels should be propagated to the _rate DQ C: Remove outdated comment Possible partially saturated ramp flagging. JP-3967 update for pllim (#1) * Undoing test changes in prep to change the C-extension, as well as analyze the test failures in the LIKELY CI tests. * Commenting out a part of a test that fails. The OLS SAT flagging needs to be updated before this test works. * Updated C-extension and tests. * Updating tests for ramp fitting cases. * Removing preprocessing switches and adding a comment, cleaning up the code. * Removing unnecessary comment. * Comments on how to update slope fitter for partial saturation flagging. * Updating the parital flagging for the rate product. Updating ramp fit tests for updating flagging. * Updating partial saturation flagging and tests. DOC: Reword second paragraph. Co-authored-by: Ken MacDonald <[email protected] m> TST: Extend test_ramp_fitting.py to LIKELY algo * Fix flagging in Python code * BUG: Fix SAT flag as suggested by Melanie Clarke and fix tests. MNT: Add __all__ to ramp_fitting/utils.py DOC: Fix DQ propagation text. TST: Un-xfail test_read_pattern_saturation_flagging from #362 * Revert changes to suppress_one_group_ramps and update tests again. Deferring this to JP-4208 or spacetelescope/jwst#10089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3164
This PR cleans up CI test removing or updating skipped or xfail'd tests.
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)"git+https://github.com/<fork>/stcal@<branch>")jwstregression testromancalregression testnews fragment change types...
changes/<PR#>.apichange.rst: change to public APIchanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.general.rst: infrastructure or miscellaneous change