Skip to content

Conversation

@scfleming
Copy link
Contributor

Partially addresses #783

This PR updates the ancillary yaml file with the latest keywords for the CGI ancillary data products (changes the name of the "type", adds MJDSTART and MJDEND instead of a single packet time). It also updates the COMMENT for the INSTRUME keyword (in both places it is found) and tightens the maximum length since the value should always be "CGI".

Tasks

  • Update or add relevant rad tests.
  • Update relevant docstrings and / or docs/ page.
  • Does this PR change any schema files?
    • Schema changes were discussed at RAD Review Board meeting.
  • Does this PR change any API used downstream? (If not, label with no-changelog-entry-needed.)

@scfleming scfleming requested review from a team and WilliamJamieson as code owners December 19, 2025 20:38
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.87%. Comparing base (6ab0be9) to head (9b1fb2e).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #788   +/-   ##
=======================================
  Coverage   85.87%   85.87%           
=======================================
  Files          14       14           
  Lines        1069     1069           
=======================================
  Hits          918      918           
  Misses        151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

destination: [CGIAncillary.instrument_name]

required: [SOURCE, PKTUTC, INSTRUME]
required: [ANCTYPE, MJDSTART, MJDEND, INSTRUME]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we should plan to report "INSTRUME" in the metadata?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for consistency and since it's easy, let's do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants